Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Vim and Windows #13

Merged
merged 5 commits into from
Feb 4, 2020
Merged

Support Vim and Windows #13

merged 5 commits into from
Feb 4, 2020

Conversation

tamago324
Copy link
Contributor

It looked like a great plugin, so I wanted to use it with Vim.
Implemented using the popup feature of Vim.

We also added Windows support.

Thank you!

Refer #8

@tamago324 tamago324 requested a review from APZelos January 23, 2020 00:41
autoload/blamer.vim Outdated Show resolved Hide resolved
Copy link
Owner

@APZelos APZelos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your contribution 😄. Can you check my suggestion before I merge it?

autoload/blamer.vim Outdated Show resolved Hide resolved
autoload/blamer.vim Outdated Show resolved Hide resolved
autoload/blamer.vim Outdated Show resolved Hide resolved
@tamago324
Copy link
Contributor Author

Thank you review 😂
Fixed.

@APZelos APZelos merged commit 9582a9a into APZelos:master Feb 4, 2020
@tamago324
Copy link
Contributor Author

Thank you for merging!

@tamago324 tamago324 deleted the vim-support branch February 4, 2020 09:06
@junkblocker
Copy link

Does this really work? In gvim (8.1.2234) I get

Error detected while processing function <lambda>9[1]..blamer#Show[23]..blamer#CreatePopup:
line   16:
E475: Invalid argument: blamer_popup_marker

@tamago324
Copy link
Contributor Author

@junkblocker How to reproduce it?

@junkblocker
Copy link

This is on macOS latest.

  1. Remove all .vimrc , .vim or move them aside etc.
  2. cd && git clone https://github.com/APZelos/blamer.nvim.git .vim
  3. cd .vim
  4. gvim
  5. :e README.md
  6. :BlamerToggle

@soohyun0131-lee
Copy link

soohyun0131-lee commented Nov 2, 2020

@junkblocker Hi, did you solve the problem? I met the same error too. (in Ubuntu 20.04)

Error detected while processing function <lambda>9[1]..blamer#Show[23]..blamer#CreatePopup:
line   16:
E475: Invalid argument: blamer_popup_marker

@junkblocker
Copy link

@mozzi0131 - I have been running VimR (nvim) instead of MacVim for a while now, so, not sure. Just tried with MacVim and :BlamerShow just shows the first line I am on when I switch it on but doesn't move to other lines as I move the cursor...so busted in different ways.

@tamago324
Copy link
Contributor Author

I also tried to get it to work on Neovim on Ubuntu recently, but it didn't work, so when I have time, I'll take a look.

@soohyun0131-lee
Copy link

@junkblocker @tamago324 Thanks for sharing! It seems like it is not working on vim, Ubuntu 20.04.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants