Symfony 5 support #1045

jmontoyaa · 2019-12-17T10:21:15Z

Fix php unit tests
Add PHP 7.2 and 7.3 in travis - (remove PHP 5.6 in travis)

jmontoyaa · 2019-12-17T10:22:49Z

I'm preparing another change to add support to Symfony 5

Thunderbird69 · 2020-01-03T15:32:18Z

SF5 support would be much appreciated ;) Thanks a bunch in advance

npotier · 2020-04-01T09:24:12Z

composer.json

@@ -21,26 +21,26 @@
    ],
    "require": {
        "php": ">=5.6",


if the composer.json maintains PHP 5.6 as minimum, shouldn't we keep the travis-ci tests with this version ?

I think is not worthy anymore to support PHP5.6 but, if we do, then yes, travis matrix should reflect this.

Then which version of PHP will be supported? From PHP 7.2?

As this bundle was "frozen" for a while, I suspect that go with 7.2 is not that crime. If we want, we could keep 7.*, don't know. As i "left" the (active) support for this bundle, I would not take a decision.

If we follow Symfony requirements, I think we should have a version (3.X) compatible with Symfony 3 / PHP 5.6 and another (4.X) compatible with Symfony 4 / PHP 7.1

There's an error when installing with PHP 7.1 (see travis ):

Because in composer.json there is:

"doctrine/mongodb-odm": "^2.0"

Error message:

- doctrine/mongodb-odm 2.0.3 requires php ^7.2 -> your PHP version (7.1.27) does not satisfy that requirement.

If I change it to "doctrine/mongodb-odm": "^1.0" then it will work, but this will downgrade some symfony packages to version 4.

So, in order to keep all the compatibilities, we should require php 7.2 as minimum php version (as I suspected). TBH I don't know if still keep a mongo support is a good idea, but as long as this bundle is really a mess of code, I would go with php7.2.
I mean, this bundle does not followed - in past - good practices both in code and in management. I think it would be hard to fix all the things at the same time.
Just my two cents, of course.

Ok, so let me get this straight : the idea would be to have a new minor version of the bundle (3.3.0) with PHP 7.2 as a minimum version in composer.json and still a Symfony 3 compatibility ?

I will send those changes, add check what travis says :D

replace transChoice with trans passing %count% as parameter

…* and fails on SF5 (https://symfony.com/blog/new-in-symfony-4-2-intlmessageformatter)

replace transchoice by trans

pierrotevrard-dbit · 2020-12-21T09:55:11Z

Got an error with this PR: Attempted to call an undefined method named "renderResponse" of class "Twig\Environment".
in vendor/apy/datagrid-bundle/Grid/Grid.php (line 2152)

The method does not exists anymore and must be replaced by a code like:

        $content = $this->container->get('twig')->renderView($view, $parameters);

        if (null === $response) {
            $response = new Response();
        }

        $response->setContent($content);

        return $response;

pierrotevrard-dbit · 2021-01-11T12:28:31Z

I've finally made a branch for Twig 3.1 compatibility, see https://github.com/pierrotevrard-dbit/APYDataGridBundle/tree/fix/twig_31_compatibility

It does not seem backward compatible with Twig 2.0, sry

Changes to run with PHP 7.4 to prevent the following error Message: Trying to access array offset on value of type null

replace spaceless by apply spaceless in blocks.html.twig

Fix "get('templating')" as in grid.php

spaceless deprecated in blocks.html.twig

spaceless in blocks.html.twig

Update GridManager.php

Change path for the exporter to work on SF5.2

Update Export.php

npotier · 2021-09-13T16:18:29Z

Hello,

I've been working on this branch https://github.com/APY/APYDataGridBundle/tree/feature/sf5-compat to have a working Bundle with latest version on Symfony 5.

All tests are green and I've created a real life example that also allows to test the bundle locally : https://github.com/npotier/apydatagrid-demo

I've created a PR here : #1063

Feel free to tell me what you think about it.

FredDut · 2021-09-13T20:52:38Z

Hello,
It's a nice job.
I think something is missing: when you filter, the column is filtered but the value disappears from the input box.
Regards

invert column exists test in grid_column_filter_type_select and grid_column_filter_type_input

Update blocks.html.twig

FredDut · 2021-10-21T09:36:49Z

Hello ,
Do you plan to merge fixes from jmontoya in sf5-compat branch?
I can't see fixes for Export.php (630a1b5) , GridManager.php (56c62e1) and spaceless in blocks.html.twig (9425cd1) in sf5-compat branch. Maybe I misunderstand something.

FredDut · 2021-11-16T14:36:05Z

I think the datagrid is OK for php7.2 with this fixes.
With php 7.4 it's not ok. When you extend the grid with custom twigs, columns or data are not initialized. Same problem for exports. I don't know what to do with this.

add fixes related to pull #1045 conversation

npotier · 2022-01-19T17:39:48Z

Hello @FredDut Thank you for your message. I've integrated the changes in the 4.0.1 tag of the bundle.

Unfortunately, I don't have access to packagist for this bundle in order to trigger an update

npotier · 2023-02-10T22:25:19Z

I think we can close this PR, as the modifications has been integrated in new versions. Feel free to add comment if necessary

jmontoyaa added 4 commits December 17, 2019 10:41

Update Twig version 2.x, fix tests

6eefbf4

Add php 7.2, 7.3 and 7.4

d873ffe

Remove PHP 5.6 tests

40e9648

Add php 7.1 remove 7.4

3ff4e7a

jmontoyaa changed the title ~~Upgrade twig version~~ Update twig version Dec 17, 2019

jmontoyaa added 4 commits January 6, 2020 14:34

Fix phpunit test add Symfony 5 support, remove Symfony 2 deps.

9c771d4

Add mongodb

3ec3cfa

Fix coveralls file name

a9d3ac8

Remove extra.symfony.require

3aa46c3

jmontoyaa changed the title ~~Update twig version~~ Symfony 5 support Feb 18, 2020

npotier added this to the 4.X milestone Apr 1, 2020

npotier reviewed Apr 1, 2020

View reviewed changes

Update PHp to version 7.2, update travis matrix

b7c8046

DonCallisto mentioned this pull request Apr 8, 2020

composer require apy/datagrid-bundle fails with symfony 5 #1054

Closed

jmontoyaa and others added 3 commits December 14, 2020 15:20

Merge pull request #1 from APY/master

fff01cb

replace transChoice with trans passing %count% as parameter

replace transchoice by trans - transChoice is deprecated since SF4.2*…

f0b6a62

…* and fails on SF5 (https://symfony.com/blog/new-in-symfony-4-2-intlmessageformatter)

Merge pull request #2 from samuelvi/replace_transchoice_by_trans

b2fae09

replace transchoice by trans

kaamaa and others added 9 commits March 12, 2021 21:09

Update services.xml

2f64264

Update services.xml

c8c7b04

Update Grid.php

efa31ac

Update Configuration.php

3f9227a

Update README.md

4848b68

Update services.xml

7a9fbb8

Update README.md

54b7b38

Update blocks.html.twig

6128364

Changes to run with PHP 7.4 to prevent the following error Message: Trying to access array offset on value of type null

spaceless in blocks.html.twig

9425cd1

replace spaceless by apply spaceless in blocks.html.twig

FredDut and others added 7 commits August 12, 2021 16:34

Update GridManager.php

56c62e1

Fix "get('templating')" as in grid.php

Merge pull request #3 from kaamaa/master

2722af4

spaceless deprecated in blocks.html.twig

Merge pull request #4 from FredDut/patch-4

82402e0

spaceless in blocks.html.twig

Merge pull request #5 from FredDut/patch-5

138764c

Update GridManager.php

Update Export.php

630a1b5

Change path for the exporter to work on SF5.2

Merge pull request #6 from samuelvi/patch-1

d31e8b8

Update Export.php

Update README.md

2e31115

FredDut and others added 2 commits October 21, 2021 08:45

Update blocks.html.twig

dd83d10

invert column exists test in grid_column_filter_type_select and grid_column_filter_type_input

Merge pull request #7 from FredDut/patch-6

a0c31b2

Update blocks.html.twig

npotier added a commit that referenced this pull request Jan 19, 2022

add fixes related to pull #1045 conversation

b269ef3

npotier added a commit that referenced this pull request Jan 19, 2022

Merge pull request #1067 from APY/feature/sf5.2-compat

0c6cd3c

add fixes related to pull #1045 conversation

npotier closed this Feb 10, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Symfony 5 support #1045

Symfony 5 support #1045

jmontoyaa commented Dec 17, 2019

jmontoyaa commented Dec 17, 2019

Thunderbird69 commented Jan 3, 2020

npotier Apr 1, 2020

DonCallisto Apr 1, 2020

jmontoyaa Apr 1, 2020

DonCallisto Apr 1, 2020

npotier Apr 1, 2020

jmontoyaa Apr 1, 2020

DonCallisto Apr 1, 2020

npotier Apr 1, 2020

DonCallisto Apr 1, 2020

jmontoyaa Apr 1, 2020

pierrotevrard-dbit commented Dec 21, 2020

pierrotevrard-dbit commented Jan 11, 2021

npotier commented Sep 13, 2021

FredDut commented Sep 13, 2021

FredDut commented Oct 21, 2021 •

edited

Loading

FredDut commented Nov 16, 2021

npotier commented Jan 19, 2022

npotier commented Feb 10, 2023

Symfony 5 support #1045

Symfony 5 support #1045

Conversation

jmontoyaa commented Dec 17, 2019

jmontoyaa commented Dec 17, 2019

Thunderbird69 commented Jan 3, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pierrotevrard-dbit commented Dec 21, 2020

pierrotevrard-dbit commented Jan 11, 2021

npotier commented Sep 13, 2021

FredDut commented Sep 13, 2021

FredDut commented Oct 21, 2021 • edited Loading

FredDut commented Nov 16, 2021

npotier commented Jan 19, 2022

npotier commented Feb 10, 2023

FredDut commented Oct 21, 2021 •

edited

Loading