Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "bouncing" when scrolling to input. #426

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix "bouncing" when scrolling to input. #426

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 11 additions & 12 deletions lib/KeyboardAwareHOC.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,18 +298,17 @@ function KeyboardAwareHOC(
if (keyboardOpeningTime === undefined) {
keyboardOpeningTime = this.props.keyboardOpeningTime || 0
}
setTimeout(() => {
if (!this.mountedComponent) {
return
}
const responder = this.getScrollResponder()
responder &&
responder.scrollResponderScrollNativeHandleToKeyboard(
reactNode,
extraHeight,
true
)
}, keyboardOpeningTime)
if (this.mountedComponent) {
UIManager.measureLayout(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@taichi-jp hey, why do you use this approach? I have removed setTimeout only and this works fine.
Also, with your approach, auto-scroll doesn't work when I press on a first input in the scrollview 🤷‍♂️

Copy link
Author

@thijs-qv thijs-qv Apr 29, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still had issues after only removing the setTimeout. Scrolling works for me on first input as well (works on my machine... 😉).

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i see :) hm, will try to find a reason 🕵️‍♂️

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementing the given solution works fine for me. When should we able to merge or find a solution to this issue? Thx

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When solution will be merged? Thanks

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this be merged someday?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope it gets merged in 2024

reactNode,
0,
() => {},
(x, y, width, height) => {
findNodeHandle(this._rnkasv_keyboardView), (x, y, width, height) => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why you use comma here?

this._rnkasv_keyboardView.scrollToPosition(0, parseInt(y) - height - extraHeight, true);
}
});
}
}

scrollIntoView = async (
Expand Down