Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

French language support #543

Merged
merged 5 commits into from
Sep 23, 2022
Merged

French language support #543

merged 5 commits into from
Sep 23, 2022

Conversation

HumorousFool
Copy link
Contributor

Describe in detail what your pull request accomplishes

This PR cleans up the existing language files and adds a new one for french.

Checklist

  • Proper internationalization
  • Tested

@TylerS1066
Copy link
Contributor

I don't speak french, but it looks good to me! I do have to review the removed and changed internationalization strings.

Copy link
Contributor

@TylerS1066 TylerS1066 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not finished looking through the changes, but I've already found a number of issues. Please review all removals you've made for usage in Movecraft.

@HumorousFool
Copy link
Contributor Author

I've re-added those messages double checked the rest of my deletions.

@TylerS1066 TylerS1066 merged commit 89776cc into APDevTeam:main Sep 23, 2022
@HumorousFool HumorousFool deleted the lang branch October 13, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants