add no-discard where applicable

src/util/cpplibostree.hpp

@@ -91,11 +91,11 @@ class OSTreeRepo {
     OstreeRepo* _c();
 
     /// Getter
-    const std::string& GetRepoPath() const;
+    [[nodiscard]] const std::string& GetRepoPath() const;
     /// Getter
-    const CommitList& GetCommitList() const;
+    [[nodiscard]] const CommitList& GetCommitList() const;
     /// Getter
-    const std::vector<std::string>& GetBranches() const;
+    [[nodiscard]] const std::vector<std::string>& GetBranches() const;
 
     // Methods
 
@@ -115,7 +115,7 @@ class OSTreeRepo {
      * @return true if the commit is signed
      * @return false if the commit is not signed
      */
-    static bool IsCommitSigned(const Commit& commit);
+    [[nodiscard]] static bool IsCommitSigned(const Commit& commit);
 
     // read & write access to OSTree repo:
 
@@ -166,23 +166,23 @@ class OSTreeRepo {
      * @param branch Branch to get most recent commit from.
      * @return Most recent commit of the specified branch.
      */
-    const Commit& GetMostRecentCommitOfBranch(const std::string& branch) const;
+    [[nodiscard]] const Commit& GetMostRecentCommitOfBranch(const std::string& branch) const;
 
     /**
      * @brief Checks if commit is the most recent commit on its branch
      *
      * @param commit Commit to check.
      * @return True, if commit is most recent on its branch.
      */
-    bool IsMostRecentCommitOnBranch(const Commit& commit) const;
+    [[nodiscard]] bool IsMostRecentCommitOnBranch(const Commit& commit) const;
 
     /**
      * @brief Checks if commit is the most recent commit on its branch
      *
      * @param hash Hash of the commit to check.
      * @return True, if commit is most recent on its branch.
      */
-    bool IsMostRecentCommitOnBranch(const std::string& hash) const;
+    [[nodiscard]] bool IsMostRecentCommitOnBranch(const std::string& hash) const;
 
    private:
     /**
@@ -217,7 +217,7 @@ class OSTreeRepo {
      *
      * @return std::string All branch names, separated by spaces
      */
-    std::string getBranchesAsString();
+    [[nodiscard]] std::string getBranchesAsString();
 
     /**
      * @brief Parse a libostree GVariant commit to a C++ commit struct.