Disable tests that may fail if the codec is not aom #1176
Conversation
| # These tests are supported with aom being the encoder and decoder. If aom is unavailable, | ||
| # these tests are disabled because other codecs may not implement all the necessary features. | ||
| # For example, SVT-AV1 requires 8-bit, 4:2:0 images with even dimensions of at least 64x64 px. | ||
| set_tests_properties(avifallocationtest avifgridapitest avifmetadatatest avifincrtest PROPERTIES DISABLED True) |
There was a problem hiding this comment.
[Just a comment, no change requested.] Disabling these tests when libaom is not available is a drastic measure. This is appropriate as a simple solution in the v0.11.1 patch release.
|
|
||
| # Lossless test. The decoded pixels should be the same as the original image. | ||
| echo "Testing basic lossless" | ||
| # TODO(yguyon): Make this test pass with INPUT_PNG instead of DECODED_FILE. |
There was a problem hiding this comment.
[Just FYI. No change requested.] I debugged this. The reason this test fails with INPUT_PNG is that avifdec does not write the Exif and XMP metadata to the output PNG file, but the are_images_equal command also compares the metadata and ICC profiles.
There was a problem hiding this comment.
Thanks. I thought I remembered the PNG was read with an opaque alpha channel, the AVIF was decoded without an alpha channel, and are_images_equal does not consider them equal because of that.
| # Cleanup | ||
| cleanup() { | ||
| pushd ${TMP_DIR} | ||
| rm -- "${ENCODED_FILE}" "${DECODED_FILE}" "${DECODED_FILE_LOSSLESS}" |
There was a problem hiding this comment.
[Just FYI. No change requested.] In these scripts, we should pass -f to the rm command, because some of these files may not exist when the test fails.
| DECODED_FILE_LOSSLESS="avif_test_cmd_decoded_lossless.png" | ||
| ENCODED_FILE="avif_test_cmd_lossless_encoded.avif" | ||
| DECODED_FILE="avif_test_cmd_lossless_decoded.png" | ||
| DECODED_FILE_LOSSLESS="avif_test_cmd_lossless_decoded_lossless.png" |
There was a problem hiding this comment.
Yannis: These tmp files are all created in ${TMP_DIR}, which is unique. So the tmp file names should not need to be unique, right?
There was a problem hiding this comment.
Right, I confused the behavior with the .cc ones. I guess /tmp might still be given as an argument for ${TMP_DIR} on some build systems so it does not hurt.
For example, the SVT-AV1 encoder requires 4:2:0 images with even dimensions of at least 64x64 px.
The first commit is just for convenience. Hide it for better diffs.