Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make with_items compatible with Ansible 2.2+ #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

codereviewvideos
Copy link

Updates main.yml inline with Ansible 2.2 syntax:

ansible/ansible-modules-core#5509

TASK [ANXS.generic-directories : generic-directories | Make sure all directories are present] ***
task path: /my/path/to/roles/ANXS.generic-directories/tasks/main.yml:3
fatal: [rancher-test4.localdomain]: FAILED! => {
    "failed": true, 
    "msg": "the field 'args' has an invalid value, which appears to include a variable that is undefined. The error was: 'ansible.vars.unsafe_proxy.AnsibleUnsafeText object' has no attribute 'path'\n\nThe error appears to have been in '/my/path/to/roles/ANXS.generic-directories/tasks/main.yml': line 3, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: \"generic-directories | Make sure all directories are present\"\n  ^ here\n"
}

thanks for this role by the way, just saved me a job :)

Updates `main.yml` inline with Ansible 2.2 syntax:

ansible/ansible-modules-core#5509

```
TASK [ANXS.generic-directories : generic-directories | Make sure all directories are present] ***
task path: /my/path/to/roles/ANXS.generic-directories/tasks/main.yml:3
fatal: [rancher-test4.localdomain]: FAILED! => {
    "failed": true, 
    "msg": "the field 'args' has an invalid value, which appears to include a variable that is undefined. The error was: 'ansible.vars.unsafe_proxy.AnsibleUnsafeText object' has no attribute 'path'\n\nThe error appears to have been in '/my/path/to/roles/ANXS.generic-directories/tasks/main.yml': line 3, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: \"generic-directories | Make sure all directories are present\"\n  ^ here\n"
}
```
@codereviewvideos
Copy link
Author

seems this is backwards incompatible with Ansible 1.5 :( np if you wish to reject, I will fork for my own use

@otakup0pe
Copy link
Member

otakup0pe commented Apr 21, 2017

Oh didn't know this was getting use! Let me update the tests for 2.2 and we can merge this ! Rebase from master and hopefully tests will be 🆗

@n1ngu
Copy link

n1ngu commented May 12, 2020

It's been a while. Like 3 years, now. 2 PRs are open proposing the same exact patch ( #6 ) to work with up-to-date Ansible versions but no movement has been observed in this repo whatsoever.

Should this be considered deadware? It's a pity, I love simple concise roles soft-wrapping Ansible modules, they save a lot of writing. But I don't like being bound to old Ansible versions!

How can the community help you to move on?

Did anyone manage to publish their fork in Ansible Galaxy?

@n1ngu
Copy link

n1ngu commented May 12, 2020

For what it is worth: @initlabopen published a fork with this fix https://galaxy.ansible.com/initlabopen/generic_directories

@otakup0pe
Copy link
Member

Always willing to have more contributors on this repo. If anyone wants in let me know. I've been holding off getting more PR's merged until I finished swapping from travis to circle but work keeps getting in the way....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants