Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMP: Fix compilation errors with latest cmake version #1012

Merged
merged 1 commit into from
Jun 8, 2020

Conversation

laurennlam
Copy link
Contributor

With the latests cmake versions, in the GUI, the generator plateform is not included into the CMAKE_GENERATOR. The default value of the generator plateforme (if it's not set by the user from the GUI), it's x84. Then, if the user sets x64, the compilation failed. All external project need to know the correct generator plateform.

@gdevenyi
Copy link
Contributor

@laurennlam can you please provide a complete report of what exactly this is trying to fix?

  • cmake version
  • OS
  • complete logs

Thanks.

@laurennlam
Copy link
Contributor Author

I used CMake 3.16.2 on Windows (and I only used the CMake GUI, not command line)
Here is the error I had on the master branch :

fatal error LNK1112: computer type module 'x86' is in conflict with target computer 'x64'

When I launched the superbuild, it tried to build ITK (and all other external project) in x86 but I explicitly define x64 on CMake GUI.

@cookpa
Copy link
Member

cookpa commented Jun 8, 2020

Thanks @laurennlam

@cookpa cookpa merged commit 1195345 into ANTsX:master Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants