Update ClusterFinderConfig - expand MC pulse width #322
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Extend MC pulse width to align data and MC. Photons hit within this larger window will be considered a "hit". 10ns is too narrow and leads to WAY too many PMT "hits" for high energy events. 35ns seems to align the number of PMT hits between data and MC.
As there are still a few things that need to be optimized for the tuning campaign, this may change in the future. Hit digitization seems like it will be changed in way of a Waveform simulator that Andrew is planning on rolling in. Therefore the pulse width may have to be changed in the future. This is a "best fit" to what we currently have.
I included the PR as James is beginning his production run for the WCSim / ToolAnalysis analysis root files.
Checklist before submitting your PR
new
usage, there is a reason the data must be on the heapnew
there is adelete
, unless I explicitly know why (e.g. ROOT or a BoostStore takes ownership)Additional Material
Slide 9 from this presentation highlights the change: https://annie-docdb.fnal.gov/cgi-bin/sso/RetrieveFile?docid=5488&filename=WCSim%20Tuning%20Status%20_%20June%203%202024%20_%20Steven%20Doran%20_%20ANNIE%20summer%20workshop%202024.pdf&version=2
Again there's more things to re-tune i just wanted to get this on board as James is about to produce some collaboration-wide files.