Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make resources base resources a simple list of resource id paths #21

Merged
merged 2 commits into from
May 24, 2023

Conversation

garethsb
Copy link
Contributor

Resolves #20

garethsb added a commit to garethsb/nmos-cpp that referenced this pull request May 23, 2023
garethsb added a commit to garethsb/nmos-cpp that referenced this pull request May 23, 2023
garethsb added a commit to garethsb/nmos-cpp that referenced this pull request May 23, 2023
Copy link
Contributor

@peterbrightwell peterbrightwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and consistent with equivalent for IS-11

@garethsb
Copy link
Contributor Author

Looks good, and consistent with equivalent for IS-11

And IS-05 /single/senders and /single/receivers, IS-07 /sources, IS-08 /inputs and /outputs, etc. 😄

The IS-04 Query API has a reason to be different, but it was an odd decision for the Node API in hindsight.

@garethsb garethsb merged commit b46b1dd into v1.0-dev May 24, 2023
@garethsb garethsb deleted the resource-list branch May 24, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Entire resources or just ID/path lists under resource types?
3 participants