Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new Laplacian for exchange BC #38

Merged
merged 73 commits into from
Feb 23, 2022
Merged

new Laplacian for exchange BC #38

merged 73 commits into from
Feb 23, 2022

Conversation

prkkumar
Copy link
Contributor

@prkkumar prkkumar commented Sep 21, 2021 •
edited
Loading

This PR is to implement the Neumann boundary conditions when the exchange interactions are taken into account. Steps include:

  1. New implementation of Laplacian operator as divergence of gradient
  2. Logic for Neumann condition based on location of the field on the grid quantity w.r.t. the interface between magnetized and non-magnetized regions.

rzamora2 and others added 30 commits June 10, 2021 11:32
change plot.period to plot.intervals
5e71370
changed plot.period to plot.intervals
b2d7bbd
@jackieyao0114
updated Examples/Tests/Macroscopic_Maxwell/inputs_3d_LLG_noMs
3a82ef3
@jackieyao0114
Merge branch 'development' of https://github.com/jackieyao0114/artemis …
7daf765 
…into development
@jackieyao0114
Merge branch 'development' of https://github.com/ECP-WarpX/artemis in…
ce7f3d8 
…to development
@ajnonaka
Merge branch 'development' of https://github.com/ECP-WarpX/artemis in…
1b9fdb1 
…to development
@ajnonaka
Merge branch 'development' of https://github.com/ECP-WarpX/artemis in…
aed980f 
…to development
@ajnonaka
Merge branch 'development' of https://github.com/ECP-WarpX/artemis in…
eea5c52 
…to development
@jackieyao0114
Merge branch 'development' of https://github.com/jackieyao0114/artemis …
328c46c 
…into development
@jackieyao0114
some tweaks Examples/Tests/Macroscopic_Maxwell/inputs_3d_LLG_noMs
3200d03
@jackieyao0114
fixed bug in getting mag_exchange_init_style and mag_anisotropy_init_…
6dde33a 
…style
@ajnonaka
Merge branch 'development' of https://github.com/jackieyao0114/artemis …
bfc0b01 
…into development
@ajnonaka
EOL whitespace
f581c09
@ajnonaka
Merge branch 'development' of https://github.com/ECP-WarpX/artemis in…
e6685e3 
…to development
@ajnonaka
Merge branch 'development' of https://github.com/ECP-WarpX/artemis in…
d603691 
…to development
@ajnonaka
Merge branch 'development' of https://github.com/ECP-WarpX/artemis in…
a61bcc1 
…to development
@ajnonaka
Merge branch 'development' of https://github.com/ECP-WarpX/artemis in…
23bf869 
…to development
@ajnonaka
Merge branch 'development' of https://github.com/ECP-WarpX/artemis in…
428471e 
…to development
@ajnonaka
Merge branch 'development' of https://github.com/ECP-WarpX/artemis in…
7f08cae 
…to development
@ajnonaka
Merge branch 'development' of https://github.com/ECP-WarpX/artemis in…
ae6397c 
…to development
@ajnonaka
Merge branch 'development' of https://github.com/ECP-WarpX/artemis in…
b78d170 
…to development
@ajnonaka
Merge branch 'development' of https://github.com/ECP-WarpX/artemis in…
8dd6bd3 
…to development
@ajnonaka
Merge branch 'development' of https://github.com/ECP-WarpX/artemis in…
58ee426 
…to development
@ajnonaka
Merge branch 'development' of https://github.com/ECP-WarpX/artemis in…
7df7291 
…to development
@ajnonaka
Merge branch 'development' of https://github.com/ECP-WarpX/artemis in…
849ccf1 
…to development
@ajnonaka
Merge branch 'development' of https://github.com/ECP-WarpX/artemis in…
5a048e1 
…to development
@ajnonaka
Merge branch 'development' of https://github.com/ECP-WarpX/artemis in…
eaa1002 
…to development
@ajnonaka
Merge branch 'development' of https://github.com/ECP-WarpX/artemis in…
57df4c6 
…to development
@ajnonaka
Merge branch 'development' of https://github.com/ECP-WarpX/artemis in…
8a6a97d 
…to development
@ajnonaka
Merge branch 'development' of https://github.com/ajnonaka/artemis int…
0d3db52 
…o development
RevathiJambunathan
RevathiJambunathan reviewed Nov 22, 2021
View reviewed changes
Source/FieldSolver/FiniteDifferenceSolver/FiniteDifferenceAlgorithms/CartesianYeeAlgorithm.H
@@ -223,6 +226,131 @@ struct CartesianYeeAlgorithm {

#endif

#ifdef WARPX_MAG_LLG
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is specific to LLG and mainly does laplacian, lets move this to a different file, in the same directory
CartesianYeeLaplacian.H
This would avoid conflicts when we merge and keep things clean

RevathiJambunathan
RevathiJambunathan requested changes Nov 23, 2021
View reviewed changes
Copy link
Collaborator

@RevathiJambunathan RevathiJambunathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR Just left a minor comment

ajnonaka and others added 18 commits November 24, 2021 12:59
@ajnonaka
bugfix; use zface only in z loop
fa1a655
@ajnonaka
revert these files
d3637db
@prkkumar
Fixes for Neumann BC
495ccfd
@prkkumar
bug fix yface
ca8195d
@prkkumar
Merge branch 'exchange_bc' of https://github.com/prkkumar/artemis int…
e10bce6 
…o exchange_bc
@jackieyao0114
added test cases input and post processing bash
3e17bcc
@prkkumar
resolve conflict
06ac081
@prkkumar
Merge branch 'exchange_bc' of github.com:prkkumar/artemis into exchan…
188683a 
…ge_bc
@jackieyao0114
fixed conflict when merging from development
598eb15
@jackieyao0114
clean up magnetic property arrays without parsing; added back lev in …
3d5af9a 
…evolveHM_2nd
@prkkumar
fixed conflict
c2c5996
@prkkumar
Merge branch 'exchange_bc' of https://github.com/prkkumar/artemis int…
cae3a93 
…o exchange_bc
@jackieyao0114
Merge branch 'development' of https://github.com/ECP-WarpX/artemis in…
5aba187 
…to my_exchange_bc
@jackieyao0114
fixed conflict when merging from prabhat exchange_bc
e9acf98
@prkkumar
Merge pull request #2 from jackieyao0114/my_exchange_bc
7e59c80 
My exchange bc
@prkkumar
style fix
68237e3
@prkkumar
EOL
6c876bb
@prkkumar
remove wrongly named files
7b86303
@ajnonaka ajnonaka merged commit 2c9c1cd into AMReX-Microelectronics:development Feb 23, 2022
@jackieyao0114 jackieyao0114 linked an issue Apr 22, 2022 that may be closed by this pull request
Need Dirichlet BC for Exchange BC #49
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackieyao0114 jackieyao0114 jackieyao0114 left review comments

@RevathiJambunathan RevathiJambunathan RevathiJambunathan requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need Dirichlet BC for Exchange BC
4 participants
@prkkumar @RevathiJambunathan @jackieyao0114 @ajnonaka