Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Submodules/amrex from f27eb69 to b3f6738 #555

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 1, 2025

Bumps Submodules/amrex from f27eb69 to b3f6738.

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [Submodules/amrex](https://github.com/AMReX-Codes/amrex) from `f27eb69` to `b3f6738`.
- [Release notes](https://github.com/AMReX-Codes/amrex/releases)
- [Commits](AMReX-Codes/amrex@f27eb69...b3f6738)

---
updated-dependencies:
- dependency-name: Submodules/amrex
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file submodules Pull requests that update Submodules code labels Jan 1, 2025
@baperry2
Copy link
Contributor

baperry2 commented Jan 2, 2025

Needed to add extra libraries to the cuda and hip dependency scripts due to changes in AMReX-Codes/amrex#4259. Considered just eliminating the dependency scripts in favor of those used in AMReX to prevent future issues, but it looks like they can't be directly swapped without additional changes, so leaving them be for now.

@baperry2 baperry2 enabled auto-merge (squash) January 2, 2025 20:29
@baperry2 baperry2 requested a review from jrood-nrel January 2, 2025 20:29
@jrood-nrel
Copy link
Contributor

I don't like the extra stuff AMReX installs, so I never adopted their scripts.

@baperry2 baperry2 merged commit 88b9f99 into development Jan 2, 2025
9 checks passed
@baperry2 baperry2 deleted the dependabot/submodules/Submodules/amrex-b3f6738 branch January 2, 2025 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file submodules Pull requests that update Submodules code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants