Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move turb inflow helpers from PeleLMeX and add documentation #489

Merged
merged 8 commits into from
Apr 15, 2024

Conversation

baperry2
Copy link
Contributor

@baperry2 baperry2 commented Apr 12, 2024

Address the long asked-for need for better documentation of the turbinflow capability

  • Brings over turbinflow support codes, which include the python script that creates the isotropic turbulence and the amrex code that repackages it for use as a turbinflow.
  • Adds documentation for the support codes and the PeleLMeX utility that handles turbinflows
  • Includes one behavior change that was necessary for the SAF project: overlapping turbinflow patches are added together rather than overwriting each other. (@SreejithNREL please confirm I put the correct change in here: 73f9f12).

Copy link
Contributor

@marchdf marchdf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work. Thank you!

Then compile the C++ executable (AMReX needed):
make

And the executable to generature the turbfile (adapt the input file to your needs):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generature -> generate

in the appendix of `Johnsen et al. (2010) J. Comp Phys. <http://dx.doi.org/10.1016/j.jcp.2009.10.028>`_. The resulting velocity
field is stored in files with names following the pattern ``hit_ic_k0_N.dat``, where ``k0`` is the most
energetic wave number and ``N`` is the size of the grid. The initial
condition for a grid of size N^3 is generated as follows:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can math the N^3 and other such math expressions below

@baperry2 baperry2 requested a review from marchdf April 15, 2024 15:48
@SreejithNREL
Copy link
Collaborator

I checked the commit and I confirm the change is correct

@baperry2 baperry2 merged commit 80f2cfa into AMReX-Combustion:development Apr 15, 2024
9 checks passed
@baperry2 baperry2 deleted the turb-inflow branch April 15, 2024 20:52
SreejithNREL pushed a commit that referenced this pull request May 27, 2024
* Bring turbulent inflow generation stuff from PeleLMeX

* some progress on documentation

* more progress on turbinflow documentation

* add option for size of wavenumber space in turbulence generation

* make multiple turbinflows additive rather than replacing each other

* fix typo and math format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants