Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add multiprocessing for ceptr #437

Merged
merged 2 commits into from
Oct 27, 2023
Merged

Add multiprocessing for ceptr #437

merged 2 commits into from
Oct 27, 2023

Conversation

marchdf
Copy link
Contributor

@marchdf marchdf commented Oct 27, 2023

No description provided.

@marchdf marchdf requested review from nickwimer and malihass October 27, 2023 14:50
@marchdf marchdf requested a review from jrood-nrel October 27, 2023 15:39
@jrood-nrel
Copy link
Contributor

Could you just do python multithreading rather than needing an MPI dependency?

@marchdf
Copy link
Contributor Author

marchdf commented Oct 27, 2023

That's a better idea. Let me try

@marchdf marchdf changed the title Add optional MPI for ceptr Add multiprocessing for ceptr Oct 27, 2023
@marchdf
Copy link
Contributor Author

marchdf commented Oct 27, 2023

Ok that was fun.

Generating all the normal mechs goes from 72s to 16s. Generating all the qss mechs goes from 1400s to 460s.

@marchdf marchdf merged commit 20d2df6 into development Oct 27, 2023
@marchdf marchdf deleted the add-mpi branch October 27, 2023 17:56
@marchdf marchdf mentioned this pull request Oct 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrood-nrel jrood-nrel jrood-nrel approved these changes

@nickwimer nickwimer Awaiting requested review from nickwimer

@malihass malihass Awaiting requested review from malihass

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marchdf @jrood-nrel