-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a cvode switch on the ordering #383
Conversation
What if we add an |
This is like a 10% performance increase in total simulation time. The option |
I'm ok with this being a compile time option, but I think the behavior here is kind of confusing. If I understand properly, this basically means a user can't choose anything besides GMRES or MAGMA on GPU without modifying source code, because the Unfortunately, I think the documentation on the chemistry integrators is so out of date that it's not even possible to add an explanation there. We really do need to address that at some point, as right now its very difficult for users to know which combinations of YC/CYOrder, EOS, hardware and solve type are valid, let alone what might be expected to be the fastest. |
In each Pele code we would add |
Shouldn't that be added to |
As it is, it breaks sparse direct. Would be nice to make the ordering a runtime variable...