Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLNodeABecLaplacian #3559

Merged
merged 4 commits into from
Oct 1, 2023
Merged

Conversation

WeiqunZhang
Copy link
Member

Add a new Linear Opearator class MLNodeABecLaplacian.

It solves (alpha * a - beta * (del dot b grad)) phi = rhs, where a, phi and rhs are nodal MultiFabs and b is cell-centered.

It works in 2D and 3D, CPU and GPU. So far it works only for single level.

There is an example of using it at Tests/LinearSolvers/ABecLaplacian_C as prob_type=4. The test problem converges at the second order.

Checklist

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

Add a new Linear Opearator class MLNodeABecLaplacian.

It solves `(alpha * a - beta * (del dot b grad)) phi = rhs`, where a, phi
and rhs are nodal MultiFabs and b is cell-centered.

It works in 2D and 3D, CPU and GPU. So far it works only for single level.

There is an example of using it at Tests/LinearSolvers/ABecLaplacian_C as
prob_type=4. The test problem converges at the second order.
@WeiqunZhang
Copy link
Member Author

Ccache on windows is broken for unknown reasons. Maybe it will come back tomorrow.

Copy link
Contributor

@ajnonaka ajnonaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve, as long as the failing CI build tests are actually not an issue.

@WeiqunZhang
Copy link
Member Author

We are having Windows CI issues because ccache no longer works. There is a PR to disable it. (#3566)

The NVHPC issue might be due to disk space issue.

@WeiqunZhang
Copy link
Member Author

In any case, I plan to merge this after the 23.10 release.

@WeiqunZhang WeiqunZhang merged commit 703a204 into AMReX-Codes:development Oct 1, 2023
@WeiqunZhang WeiqunZhang deleted the nodeabeclap branch October 1, 2023 18:30
guj pushed a commit to guj/amrex that referenced this pull request Dec 13, 2023
Add a new Linear Opearator class MLNodeABecLaplacian.

It solves `(alpha * a - beta * (del dot b grad)) phi = rhs`, where a,
phi and rhs are nodal MultiFabs and b is cell-centered.

It works in 2D and 3D, CPU and GPU. So far it works only for single
level.

There is an example of using it at Tests/LinearSolvers/ABecLaplacian_C
as prob_type=4. The test problem converges at the second order.

---------

Co-authored-by: Andy Nonaka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants