Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Time step in the AmrLevel test #2763

Merged
merged 1 commit into from
May 12, 2022
Merged

Time step in the AmrLevel test #2763

merged 1 commit into from
May 12, 2022

Conversation

WeiqunZhang
Copy link
Member

@WeiqunZhang WeiqunZhang commented May 12, 2022 •
edited
Loading

Make the dt in the AmrLevel test consistent with that in the AmrCore Test.
That is we use the velocity at t+0.5*dt (here dt is from the previous step)
to estimate the dt for the next step.

Checklist

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

@WeiqunZhang
Time step in the AmrLevel test
d754e2a 
Make the dt in the AmrLevel test consistent with that in the AmrCore Test.
That is we use the velocity at t+0.5*dt (here dt is from the previous step)
to estimate the dt for the next step.
@WeiqunZhang WeiqunZhang requested review from atmyers and etpalmer63 May 12, 2022 00:54
@WeiqunZhang WeiqunZhang merged commit 5aa61b2 into AMReX-Codes:development May 12, 2022
@WeiqunZhang WeiqunZhang deleted the amrlev_dt branch May 12, 2022 16:29
kngott pushed a commit to kngott/amrex that referenced this pull request May 19, 2022
@WeiqunZhang @kngott
Time step in the AmrLevel test (AMReX-Codes#2763)
45f9617 
Make the dt in the AmrLevel test consistent with that in the AmrCore Test.
That is we use the velocity at t+0.5*dt (here dt is from the previous step)
to estimate the dt for the next step.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etpalmer63 etpalmer63 etpalmer63 approved these changes

@atmyers atmyers Awaiting requested review from atmyers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WeiqunZhang @etpalmer63