-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HDF5 H5Z-ZFP support in CMake #2753
Add HDF5 H5Z-ZFP support in CMake #2753
Conversation
Uff, yes HDF5 is just about to fully modernize their CMake infrastructure and fix all bug reports: https://github.com/HDFGroup/hdf5/issues?q=is%3Aissue+is%3Aopen+cmake On Unix systems, use Autotools still until this process is complete. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks great, thank you!
Please add the new option in the user-facing docs in Docs/sphinx_documentation/source/BuildingAMReX.rst
as well :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the contribution!
Summary
This adds HDF5 ZFP lossy compression support to plot files within CMake.
Additional background
I've tested this as much as I could on my own. I'm finding that the variable in CMake
HDF5_IS_PARALLEL
may not get populated correctly (at least with CMake 3.23.1 on MacOS), which appears to be a bug in CMake. I think this also depends on whether HDF5 was installed using Autotools or CMake as the installation is totally different between both. This is unfortunate because we want the logic for matching HDF5 with or without MPI to AMReX with or without MPI, but CMake can fail in this logic because it reports parallel HDF5 wrong.Closes #2696
Checklist
The proposed changes: