New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coverity fix #2998

Merged

zingale merged 1 commit into AMReX-Astro:development from zhichen3:coverity_fix

Nov 21, 2024

Collaborator

zhichen3 commented Nov 20, 2024

PR summary

the original intention is to not execute the loop when spacedim=2, but coverity complains that its dead code.

PR motivation

PR checklist

test suite needs to be run on this PR
this PR will change answers in the test suite to more than roundoff level
all newly-added functions have docstrings as per the coding conventions
the CHANGES file has been updated, if appropriate
if appropriate, this change is described in the docs


          make coverity happy

6191e2d

zingale approved these changes

View reviewed changes

zingale merged commit 8b3196a into AMReX-Astro:development

25 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet