CMake: fix scope for -DHAS_BOOST_CHRONO #2163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2163 +/- ##
===========================================
- Coverage 76.74% 76.66% -0.08%
===========================================
Files 82 82
Lines 14943 14940 -3
===========================================
- Hits 11468 11454 -14
- Misses 3475 3486 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
|
FFroehlich
approved these changes
Aug 24, 2023
💩 Previously, this could lead to invalid writes and segfaults, because the base library would have a boost version of CpuTimer, and the model extension would have or assume a non-boost version of CpuTimer. I don't know whether or how it is defined which definition would be used. I only found one environment where this would happen (segfaults on gcc/12.2.0, boost/1.82.0 (e.g. `valgrind python -c "import SomeModel as m; model = m.getModel(); model.getSolver()"`); no problems with gcc/12.3.0 boost/1.74.0).
dweindl
force-pushed
the
fix_boost_chrono_define
branch
from
b82f510 to
9151f87
Compare
…re using thread_clock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue of potentially mixing boost and non-boost versions of CpuTimer.
Previously, this could lead to invalid writes and segfaults, because the base library would have a boost version of CpuTimer, and the model extension would have or assume a non-boost version of CpuTimer. I don't know whether or how it is defined which definition would be used. I only found one environment where this would happen (segfaults on gcc/12.2.0, boost/1.82.0 (e.g.valgrind python -c "import SomeModel as m; model = m.getModel(); model.getSolver()"); no problems with gcc/12.3.0 boost/1.74.0).Turns out the segfaults were caused by a broken boost installation (it seems when building boost-1.8{1,2}.0 with cxxstd=98, at least chrono is broken).