Remove complex / complex long KLU functions #2160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are unnecessarily building the complex / complex long versions of KLU. This PR removes them to speed up AMICI installation. We are still building both the int32_t and int64_t version of SuiteSparse, which leaves room for further optimization...
dweindl
force-pushed
the
klu_no_complex
branch
from
2044573 to
849d829
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2160 +/- ##
============================================
+ Coverage 54.26% 76.67% +22.41%
============================================
Files 34 82 +48
Lines 5586 14943 +9357
============================================
+ Hits 3031 11457 +8426
- Misses 2555 3486 +931
Flags with carried forward coverage won't be shown. Click here to find out more. |
FFroehlich
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are unnecessarily building the complex / complex long versions of KLU. This PR removes them to speed up AMICI installation.
We are still building both the int32_t and int64_t version of SuiteSparse, which leaves room for further optimization...