Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SBML import for event-assigned parameters with non-float initial assignments #2156

Merged
merged 4 commits into from
Aug 16, 2023
Merged

Fix SBML import for event-assigned parameters with non-float initial assignments #2156

merged 4 commits into from
Aug 16, 2023

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Jul 31, 2023 •
edited
Loading

Currently it is incorrectly assumed that the initial value of an event-assigned parameter
is (convertible to) a float. Therefore, SBML import fails if the initial assignment
contains a symbolic expression that can't be floatified.

Fixes #2149.

@dweindl
Fix SBML import for event-assigned parameters with non-float initial …
fb6b191 
…assignments

Currently it is incorrectly assumed that the initial value of an event-assigned parameter
is (convertible to) a float. Therefore, SBML import fails if the initial assignment
contains a symbolic expression that can't be floatified.

Fixes #2149.
@dweindl dweindl changed the base branch from master to develop July 31, 2023 10:52
@dweindl dweindl changed the title Fix 2149 Fix SBML import for event-assigned parameters with non-float initial assignments Jul 31, 2023
@codecov
Copy link

codecov bot commented Jul 31, 2023 •
edited
Loading

Codecov Report

Merging #2156 (a2b7da4) into develop (3cd3494) will decrease coverage by 0.05%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2156      +/-   ##
===========================================
- Coverage    76.67%   76.63%   -0.05%     
===========================================
  Files           82       82              
  Lines        14943    14943              
===========================================
- Hits         11457    11451       -6     
- Misses        3486     3492       +6
Flag Coverage Δ
cpp 73.49% <ø> (-0.07%) ⬇️
petab 54.26% <ø> (ø)
python 77.29% <ø> (ø)
sbmlsuite ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
python/sdist/amici/sbml_import.py 77.83% <ø> (ø)

... and 3 files with indirect coverage changes

@dweindl dweindl marked this pull request as ready for review July 31, 2023 13:19
@dweindl dweindl requested a review from a team as a code owner July 31, 2023 13:19
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

FFroehlich
FFroehlich approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@FFroehlich FFroehlich left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

parameter_def["value"] was assigned using _sympy_from_sbml_math, right?

@dweindl
Copy link
Member Author

dweindl commented Aug 16, 2023

parameter_def["value"] was assigned using _sympy_from_sbml_math, right?

True. We don't need another sympification. Removed it.

@dweindl dweindl merged commit fa69dd3 into develop Aug 16, 2023
@dweindl dweindl deleted the fix_2149 branch August 16, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FFroehlich FFroehlich FFroehlich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dweindl @FFroehlich