SBML import: Allow hardcoding of numerical values #2134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2134 +/- ##
========================================
Coverage 76.66% 76.67%
========================================
Files 81 81
Lines 14920 14926 +6
========================================
+ Hits 11439 11445 +6
Misses 3481 3481
Flags with carried forward coverage won't be shown. Click here to find out more.
|
FFroehlich
approved these changes
Jun 29, 2023
| raise ValueError( | ||
| f"Cannot hardcode symbol `{c.getId()}` that is a rule target." | ||
| ) | ||
| if self.sbml.getInitialAssignment(c.getId()): |
There was a problem hiding this comment.
add event assignements. What about assignment rules?
There was a problem hiding this comment.
Event assignments were missing, true. Assignment rules were handled by getRuleByVariable. Now changed to checking for the constant attribute which covers both.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows selecting parameters whose values are to be hard-coded (#1192).
So far, restricted to parameters that aren't targets of rule or initial assignments.
This can be extended later: lifting those restrictions on parameters, allow hard-coding Species with constant=True, ...