Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PEtab deprecation warning #2122

Merged
merged 2 commits into from
Jun 19, 2023
Merged

Fix PEtab deprecation warning #2122

merged 2 commits into from
Jun 19, 2023

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Jun 19, 2023

Fixes /home/runner/work/AMICI/AMICI/python/tests/splines_utils.py:265: DeprecationWarning: The sbml_fileargument is deprecated and will be removed in a future version. Usemodel_file instead.

Fixes `/home/runner/work/AMICI/AMICI/python/tests/splines_utils.py:265: DeprecationWarning: The `sbml_file` argument is deprecated and will be removed in a future version. Use `model_file` instead.`
@dweindl dweindl requested a review from a team as a code owner June 19, 2023 06:37
@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Merging #2122 (cce4c54) into develop (0010985) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2122   +/-   ##
========================================
  Coverage    54.38%   54.38%           
========================================
  Files           33       33           
  Lines         5518     5518           
========================================
  Hits          3001     3001           
  Misses        2517     2517           
Flag Coverage Δ
petab 54.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dweindl dweindl enabled auto-merge June 19, 2023 10:49
@dweindl dweindl requested a review from dilpath June 19, 2023 16:46
Copy link
Member

@FFroehlich FFroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dweindl dweindl disabled auto-merge June 19, 2023 16:59
@dweindl dweindl merged commit 02555e3 into develop Jun 19, 2023
@dweindl dweindl deleted the fix_petab_depr branch June 19, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants