Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[petab] fix pysb pattern matching #2118

Merged
merged 2 commits into from
Jun 5, 2023
Merged

[petab] fix pysb pattern matching #2118

merged 2 commits into from
Jun 5, 2023

Conversation

FFroehlich
Copy link
Member

@FFroehlich FFroehlich commented Jun 2, 2023

can't assume equations have been generated and SpeciesPatternMatcher won't work otherwise.

@FFroehlich FFroehlich requested a review from a team as a code owner June 2, 2023 17:14
@FFroehlich FFroehlich changed the title fix pattern matching [petab] fix pysb pattern matching Jun 2, 2023
@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Merging #2118 (fa2b742) into develop (0fc51c0) will increase coverage by 0.05%.
The diff coverage is 50.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2118      +/-   ##
===========================================
+ Coverage    76.53%   76.59%   +0.05%     
===========================================
  Files           81       81              
  Lines        14857    14859       +2     
===========================================
+ Hits         11371    11381      +10     
+ Misses        3486     3478       -8     
Flag Coverage Δ
cpp 73.55% <ø> (-0.05%) ⬇️
petab 54.38% <50.00%> (-0.01%) ⬇️
python 76.99% <0.00%> (+0.21%) ⬆️
sbmlsuite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/sdist/amici/petab_util.py 89.65% <50.00%> (-2.94%) ⬇️

... and 3 files with indirect coverage changes

Copy link
Member

@dweindl dweindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@FFroehlich FFroehlich enabled auto-merge June 5, 2023 09:07
@FFroehlich FFroehlich added this pull request to the merge queue Jun 5, 2023
Merged via the queue into develop with commit da3a9ef Jun 5, 2023
dweindl added a commit to ICB-DCM/pyPESTO that referenced this pull request Jun 5, 2023
@dweindl dweindl deleted the fix_pysb_petab branch June 9, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants