Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify visualization dependencies #2070

Merged
merged 3 commits into from
May 9, 2023
Merged

Specify visualization dependencies #2070

merged 3 commits into from
May 9, 2023

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented May 8, 2023

So far, matplotlib was implicitly required through petab. In petab==0.2.0, matplotlib became an optional dependency.

So far, matplotlib was implicitly required through petab. In petab==0.2.0, matplotlib became an optional dependency.
@dweindl dweindl requested a review from a team as a code owner May 8, 2023 15:58
@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Merging #2070 (9f8e853) into develop (1ee58c4) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2070   +/-   ##
========================================
  Coverage    53.73%   53.73%           
========================================
  Files           29       29           
  Lines         4548     4548           
========================================
  Hits          2444     2444           
  Misses        2104     2104           
Flag Coverage Δ
petab 53.73% <ø> (ø)
sbmlsuite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@dweindl dweindl self-assigned this May 8, 2023
@dweindl dweindl requested a review from FFroehlich May 8, 2023 17:13
FFroehlich pushed a commit that referenced this pull request May 8, 2023
* Specify visualization dependencies

So far, matplotlib was implicitly required through petab. In petab==0.2.0, matplotlib became an optional dependency.

* ..
@dweindl dweindl merged commit 255be19 into develop May 9, 2023
@dweindl dweindl deleted the mpl branch May 9, 2023 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants