Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sympy symbol name clashes during PEtab import #2069

Merged
merged 4 commits into from
May 9, 2023
Merged

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented May 8, 2023

Closes #2055

@dweindl dweindl requested a review from a team as a code owner May 8, 2023 13:31
@dweindl dweindl linked an issue May 8, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Merging #2069 (f497360) into develop (f8929b9) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2069   +/-   ##
========================================
  Coverage    54.90%   54.90%           
========================================
  Files           30       30           
  Lines         4617     4617           
========================================
  Hits          2535     2535           
  Misses        2082     2082           
Flag Coverage Δ
petab 54.90% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/sdist/amici/petab_objective.py 93.77% <ø> (ø)
python/sdist/amici/petab_import.py 69.41% <100.00%> (ø)

@dweindl dweindl self-assigned this May 8, 2023
@FFroehlich
Copy link
Member

intentional that this doesn't cover all call to sympy.sympify?

@dweindl
Copy link
Member Author

dweindl commented May 9, 2023

intentional that this doesn't cover all call to sympy.sympify?

Yes. The ones in the SBML and PySB importers should be fine. There, we already gather all model symbols beforehand and pass them as locals.

@dweindl dweindl merged commit ba70f54 into develop May 9, 2023
@dweindl dweindl deleted the fix_2055 branch May 9, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use locals for all sympifications
2 participants