Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake: Handle header-dependency of swig files #2046

Merged
merged 1 commit into from
Apr 16, 2023
Merged

CMake: Handle header-dependency of swig files #2046

merged 1 commit into from
Apr 16, 2023

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Apr 15, 2023

Fixes #2044

@dweindl dweindl requested a review from a team as a code owner April 15, 2023 21:23
@dweindl dweindl enabled auto-merge April 15, 2023 21:23
@codecov
Copy link

codecov bot commented Apr 15, 2023 •
edited
Loading

Codecov Report

Merging #2046 (0d31f2a) into develop (f656203) will decrease coverage by 0.03%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2046      +/-   ##
===========================================
- Coverage    75.29%   75.26%   -0.03%     
===========================================
  Files           75       75              
  Lines        13011    13011              
===========================================
- Hits          9796     9793       -3     
- Misses        3215     3218       +3
Flag Coverage Δ
cpp 72.85% <ø> (-0.04%) ⬇️
petab 53.75% <ø> (ø)
python 69.62% <ø> (ø)
sbmlsuite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

FFroehlich
FFroehlich approved these changes Apr 16, 2023
View reviewed changes
Copy link
Member

@FFroehlich FFroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dweindl dweindl disabled auto-merge April 16, 2023 19:29
@dweindl dweindl merged commit c585b90 into develop Apr 16, 2023
@dweindl dweindl deleted the fix_2044_swigdeps branch April 16, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FFroehlich FFroehlich FFroehlich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dweindl @FFroehlich