Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove model name prefix in generated model files #2015

Merged
merged 11 commits into from
Feb 23, 2023
Merged

Remove model name prefix in generated model files #2015

merged 11 commits into from
Feb 23, 2023

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Feb 23, 2023

Helps to avoid issues with too long paths on Windows 💩

Helps to avoid issues with too long paths on Windows 💩
@dweindl dweindl requested a review from a team as a code owner February 23, 2023 14:15
@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Merging #2015 (79596cc) into develop (2aef279) will increase coverage by 0.96%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2015      +/-   ##
===========================================
+ Coverage    76.16%   77.13%   +0.96%     
===========================================
  Files           76       76              
  Lines        13004    13004              
===========================================
+ Hits          9904    10030     +126     
+ Misses        3100     2974     -126     
Flag Coverage Δ
cpp 73.36% <ø> (ø)
petab 60.03% <100.00%> (ø)
python 71.64% <100.00%> (+2.79%) ⬆️
sbmlsuite ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/sdist/amici/ode_export.py 91.74% <100.00%> (ø)
...thon/sdist/amici/conserved_quantities_demartino.py 90.21% <0.00%> (+24.65%) ⬆️

models/model_calvetti/model_calvetti.h Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@dweindl dweindl merged commit 6819ebf into develop Feb 23, 2023
@dweindl dweindl deleted the no_prefix branch February 23, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants