Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error logging in steadystate solver #2008

Merged
merged 8 commits into from
Feb 22, 2023
Merged

Fix error logging in steadystate solver #2008

merged 8 commits into from
Feb 22, 2023

Conversation

FFroehlich
Copy link
Member

@FFroehlich FFroehlich commented Feb 21, 2023

@FFroehlich FFroehlich requested a review from a team as a code owner February 21, 2023 16:57
Copy link
Member

@dweindl dweindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Merging #2008 (63fd3c2) into develop (bd37745) will increase coverage by 0.18%.
The diff coverage is 76.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2008      +/-   ##
===========================================
+ Coverage    75.99%   76.17%   +0.18%     
===========================================
  Files           76       76              
  Lines        12996    13002       +6     
===========================================
+ Hits          9876     9904      +28     
+ Misses        3120     3098      -22     
Flag Coverage Δ
cpp 73.36% <76.00%> (+0.16%) ⬆️
petab 60.05% <ø> (ø)
python 68.88% <ø> (+0.22%) ⬆️
sbmlsuite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/amici.cpp 84.07% <ø> (ø)
src/solver.cpp 76.67% <70.00%> (-0.20%) ⬇️
src/steadystateproblem.cpp 86.45% <80.00%> (+3.16%) ⬆️
src/solver_cvodes.cpp 70.23% <0.00%> (+0.16%) ⬆️
...thon/sdist/amici/conserved_quantities_demartino.py 65.55% <0.00%> (+1.95%) ⬆️

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@FFroehlich FFroehlich merged commit 3986f4e into develop Feb 22, 2023
@FFroehlich FFroehlich deleted the fix_errors branch February 22, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants