PEtab import: allow specifying default values for output parameters #1987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows specifying default parameter values for output parameters introduced in the PEtab observables table. This is convenient for placeholder parameters, for which the current value of 0.0 is not good choice (e.g. scaling parameters). Allows for meaningful model outputs if the model is just simulated with default parameters.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1987 +/- ##
===========================================
+ Coverage 75.99% 76.06% +0.06%
===========================================
Files 76 76
Lines 12983 12995 +12
===========================================
+ Hits 9867 9884 +17
+ Misses 3116 3111 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
SonarCloud Quality Gate failed. |
FFroehlich
approved these changes
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows specifying default parameter values for output parameters introduced in the PEtab observables table. This is convenient for placeholder parameters, for which the current value of 0.0 is not good choice (e.g. scaling parameters). Allows for meaningful model outputs if the model is just simulated with default parameters.