Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print stacktraces only with debug logging level #1985

Merged
merged 2 commits into from
Feb 13, 2023
Merged

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Feb 11, 2023

Closes #1943

@dweindl dweindl requested a review from a team as a code owner February 11, 2023 21:09
@codecov
Copy link

codecov bot commented Feb 11, 2023

Codecov Report

Merging #1985 (ffd4e43) into develop (e51815d) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1985   +/-   ##
========================================
  Coverage    59.72%   59.72%           
========================================
  Files           30       30           
  Lines         4584     4584           
========================================
  Hits          2738     2738           
  Misses        1846     1846           
Flag Coverage Δ
petab 59.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@FFroehlich FFroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice, easier than anticipated :D

@dweindl dweindl merged commit 4f6fc24 into develop Feb 13, 2023
@dweindl dweindl deleted the fix_1943_debug_trace branch February 13, 2023 08:46
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants