Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PytestReturnNotNoneWarning in test_conserved_quantities_demartino.py #1968

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Jan 31, 2023

Fixes

  C:\hostedtoolcache\windows\Python\3.8.10\x64\lib\site-packages\_pytest\python.py:199: PytestReturnNotNoneWarning: Expected None, but python/tests/test_conserved_quantities_demartino.py::test_compute_moiety_conservation_laws_demartino2014 returned 7.324800299999993, which will be an error in a future version of pytest.  Did you mean to use `assert` instead of `return`?

Fixes
```
  C:\hostedtoolcache\windows\Python\3.8.10\x64\lib\site-packages\_pytest\python.py:199: PytestReturnNotNoneWarning: Expected None, but python/tests/test_conserved_quantities_demartino.py::test_compute_moiety_conservation_laws_demartino2014 returned 7.324800299999993, which will be an error in a future version of pytest.  Did you mean to use `assert` instead of `return`?
```
@dweindl dweindl requested a review from a team as a code owner January 31, 2023 14:25
@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Merging #1968 (d3d51c3) into develop (b61abb6) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1968      +/-   ##
===========================================
- Coverage    75.98%   75.97%   -0.01%     
===========================================
  Files           76       76              
  Lines        12984    12984              
===========================================
- Hits          9866     9865       -1     
- Misses        3118     3119       +1     
Flag Coverage Δ
cpp 73.13% <ø> (-0.02%) ⬇️
petab 59.71% <ø> (ø)
python 68.97% <ø> (ø)
sbmlsuite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/amici.cpp 71.77% <0.00%> (-4.04%) ⬇️
src/exception.cpp 74.28% <0.00%> (ø)
src/solver_cvodes.cpp 70.06% <0.00%> (ø)
src/sundials_matrix_wrapper.cpp 81.02% <0.00%> (+0.81%) ⬆️

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Member

@FFroehlich FFroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dweindl dweindl merged commit 77c5339 into develop Jan 31, 2023
@dweindl dweindl deleted the fix_PytestReturnNotNoneWarning branch January 31, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants