Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc: Instructions for AMICI with singularity #1964

Merged
merged 3 commits into from
Jan 30, 2023
Merged

Doc: Instructions for AMICI with singularity #1964

merged 3 commits into from
Jan 30, 2023

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Jan 29, 2023

  • how to create a container
  • make Dockerfile compatible with spython/singularity
  • mv docker/ container/

@dweindl
Doc: Instructions for AMICI with singularity
5588fb9 
* how to create a container
* make Dockerfile compatible with spython/singularity
* mv docker/ container/
@dweindl dweindl requested a review from a team as a code owner January 29, 2023 09:36
@codecov
Copy link

codecov bot commented Jan 29, 2023 •
edited
Loading

Codecov Report

Merging #1964 (10bd852) into develop (13cde9d) will increase coverage by 0.13%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1964      +/-   ##
===========================================
+ Coverage    75.99%   76.12%   +0.13%     
===========================================
  Files           76       76              
  Lines        12982    12982              
===========================================
+ Hits          9866     9883      +17     
+ Misses        3116     3099      -17
Flag Coverage Δ
cpp 73.19% <ø> (+0.04%) ⬆️
petab 59.74% <ø> (ø)
python 69.29% <ø> (+0.28%) ⬆️
sbmlsuite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/sundials_matrix_wrapper.cpp 81.02% <0.00%> (+0.81%) ⬆️
python/sdist/amici/gradient_check.py 96.84% <0.00%> (+13.68%) ⬆️

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

FFroehlich
FFroehlich approved these changes Jan 30, 2023
View reviewed changes
Copy link
Member

@FFroehlich FFroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dweindl dweindl merged commit 12718e6 into develop Jan 30, 2023
@dweindl dweindl deleted the singularity branch January 30, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FFroehlich FFroehlich FFroehlich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dweindl @FFroehlich