Always check for finite x0 #1955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial states should always be checked for finite values, not only with `Model.setAlwaysCheckFinite(True)`. As this only happens once per simulation, the overhead is negligible. Closes #1952
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1955 +/- ##
===========================================
+ Coverage 75.96% 76.01% +0.04%
===========================================
Files 76 76
Lines 12981 13015 +34
===========================================
+ Hits 9861 9893 +32
- Misses 3120 3122 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
this is an abysmal pain to look at, can we separate clang formats from actual changes? |
dweindl
commented
Jan 24, 2023
dweindl
commented
Jan 24, 2023
oops. didn't notice there was so much. I'll just clang-format everything later, then that issue should be solved for the near future. |
This reverts commit a09c4d1.
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial states should always be checked for finite values, not only with
Model.setAlwaysCheckFinite(True). As this only happens once per simulation, the overhead is negligible.Closes #1952