Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log all nested execution times as debug #1947

Merged
merged 2 commits into from
Jan 18, 2023
Merged

Conversation

FFroehlich
Copy link
Member

reduces verbosity of model compilation

@FFroehlich FFroehlich requested a review from dweindl January 18, 2023 14:49
@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Merging #1947 (88ebbcc) into develop (32db671) will increase coverage by 0.10%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1947      +/-   ##
===========================================
+ Coverage    75.96%   76.06%   +0.10%     
===========================================
  Files           76       76              
  Lines        12977    12979       +2     
===========================================
+ Hits          9858     9873      +15     
+ Misses        3119     3106      -13     
Flag Coverage Δ
cpp 73.13% <ø> (ø)
petab 59.68% <100.00%> (+0.01%) ⬆️
python 69.24% <100.00%> (+0.30%) ⬆️
sbmlsuite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/sdist/amici/logging.py 84.12% <100.00%> (+0.52%) ⬆️
python/sdist/amici/gradient_check.py 96.84% <0.00%> (+13.68%) ⬆️

Copy link
Member

@dweindl dweindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@FFroehlich FFroehlich merged commit c25c666 into develop Jan 18, 2023
@FFroehlich FFroehlich deleted the reduce_compilation_output branch January 18, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants