Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip irrelevant frames in stacktraces #1934

Merged
merged 4 commits into from
Jan 16, 2023
Merged

Skip irrelevant frames in stacktraces #1934

merged 4 commits into from
Jan 16, 2023

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Jan 14, 2023

  • Add optional startlevel for stacktrace
  • Fix maxLevel, which should be interpreted relative to the startlevel

(+ some clang-format)

* Add optional startlevel for stacktrace
* Fix maxLevel, which should be interpreted relative to the startlevel
@dweindl dweindl requested a review from FFroehlich January 14, 2023 14:26
@codecov
Copy link

codecov bot commented Jan 14, 2023

Codecov Report

Merging #1934 (bcbae30) into develop (6e44a70) will increase coverage by 0.12%.
The diff coverage is 91.17%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1934      +/-   ##
===========================================
+ Coverage    75.99%   76.11%   +0.12%     
===========================================
  Files           76       76              
  Lines        12970    12969       -1     
===========================================
+ Hits          9857     9872      +15     
+ Misses        3113     3097      -16     
Flag Coverage Δ
cpp 73.16% <91.17%> (+0.03%) ⬆️
petab 59.72% <ø> (ø)
python 69.31% <ø> (+0.28%) ⬆️
sbmlsuite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/exception.cpp 80.00% <82.35%> (+4.32%) ⬆️
include/amici/misc.h 83.72% <100.00%> (ø)
src/misc.cpp 68.93% <100.00%> (+0.30%) ⬆️
src/solver_cvodes.cpp 70.23% <0.00%> (+0.16%) ⬆️
python/sdist/amici/gradient_check.py 96.84% <0.00%> (+13.68%) ⬆️

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

include/amici/exception.h Show resolved Hide resolved
@dweindl dweindl merged commit 8c58eb3 into develop Jan 16, 2023
@dweindl dweindl deleted the stacktrace branch January 16, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants