Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiArch docker build #1903

Merged
merged 14 commits into from
Nov 30, 2022
Merged

MultiArch docker build #1903

merged 14 commits into from
Nov 30, 2022

Conversation

FFroehlich
Copy link
Member

fixes #1902

@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Merging #1903 (f94e9d7) into develop (df0a881) will decrease coverage by 0.87%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1903      +/-   ##
===========================================
- Coverage    76.74%   75.86%   -0.88%     
===========================================
  Files           75       75              
  Lines        12913    12913              
===========================================
- Hits          9910     9797     -113     
- Misses        3003     3116     +113     
Flag Coverage Δ
cpp 72.82% <ø> (ø)
petab 59.82% <ø> (ø)
python 69.26% <ø> (-2.55%) ⬇️
sbmlsuite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...thon/sdist/amici/conserved_quantities_demartino.py 65.55% <0.00%> (-24.66%) ⬇️
src/sundials_matrix_wrapper.cpp 80.61% <0.00%> (ø)
python/sdist/amici/gradient_check.py 96.84% <0.00%> (+13.68%) ⬆️

@FFroehlich FFroehlich marked this pull request as ready for review November 28, 2022 08:40
@FFroehlich FFroehlich requested a review from dweindl November 28, 2022 08:40
@FFroehlich
Copy link
Member Author

Copy link
Member

@dweindl dweindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

docker/Dockerfile Outdated Show resolved Hide resolved
docker/Dockerfile Show resolved Hide resolved
docker/Dockerfile Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@FFroehlich FFroehlich merged commit 27f26a0 into develop Nov 30, 2022
@FFroehlich FFroehlich deleted the multiarch_docker branch November 30, 2022 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants