Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential deadlocks during parallel simplification #1844

Merged
merged 2 commits into from
Aug 4, 2022
Merged

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Aug 4, 2022

For larger models, I experienced occassional deadlocks during import. Unclear why.
Most such issues seem to be related to forking, so let's do without.

For larger models, I experienced occassional deadlocks during import. Unclear why.
Most such issues seem to be related to forking, so let's do without.
@dweindl dweindl requested a review from FFroehlich August 4, 2022 08:45
@codecov
Copy link

codecov bot commented Aug 4, 2022

Codecov Report

Merging #1844 (3a6acd4) into develop (7cf65d1) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1844      +/-   ##
===========================================
- Coverage    76.09%   76.08%   -0.01%     
===========================================
  Files           74       74              
  Lines        12684    12685       +1     
===========================================
  Hits          9652     9652              
- Misses        3032     3033       +1     
Flag Coverage Δ
cpp 72.71% <ø> (ø)
petab 59.38% <0.00%> (-0.02%) ⬇️
python 68.36% <0.00%> (-0.02%) ⬇️
sbmlsuite 88.42% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/amici/ode_export.py 92.39% <0.00%> (-0.12%) ⬇️

Copy link
Member

@FFroehlich FFroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice!

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@dweindl dweindl merged commit 1f5e5ef into develop Aug 4, 2022
@dweindl dweindl deleted the fix_spawn branch August 4, 2022 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants