fix_cls #1833

FFroehlich · 2022-07-18T15:48:05Z

Fixes an issue where flattening would end up in an infinite loop due to coefficients of a cl state being 0.0. Harmonizing checks should be future proof.

dweindl

👍

codecov · 2022-07-18T16:00:32Z

Codecov Report

Merging #1833 (2d26218) into develop (b620239) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #1833      +/-   ##
===========================================
+ Coverage    76.02%   76.10%   +0.07%     
===========================================
  Files           74       74              
  Lines        12673    12676       +3     
===========================================
+ Hits          9635     9647      +12     
+ Misses        3038     3029       -9

Flag	Coverage Δ
cpp	`72.72% <ø> (+0.10%)`	⬆️
petab	`59.48% <28.57%> (-0.02%)`	⬇️
python	`68.37% <100.00%> (+0.02%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
python/amici/pysb_import.py	`94.61% <100.00%> (+0.04%)`	⬆️
src/solver_cvodes.cpp	`70.18% <0.00%> (-0.17%)`	⬇️
src/sundials_matrix_wrapper.cpp	`80.65% <0.00%> (+0.40%)`	⬆️
src/amici.cpp	`71.73% <0.00%> (+4.34%)`	⬆️
src/exception.cpp	`81.08% <0.00%> (+5.40%)`	⬆️