Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ImportErrors during package installation with recent setuptools #1830

Merged
merged 1 commit into from
Jul 15, 2022

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Jul 14, 2022

Closes #1829

@codecov
Copy link

codecov bot commented Jul 14, 2022

Codecov Report

Merging #1830 (92213f2) into develop (7bc909b) will decrease coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1830      +/-   ##
===========================================
- Coverage    76.26%   76.09%   -0.17%     
===========================================
  Files           74       74              
  Lines        12669    12669              
===========================================
- Hits          9662     9641      -21     
- Misses        3007     3028      +21     
Flag Coverage Δ
cpp 72.72% <ø> (-0.13%) ⬇️
petab 59.50% <ø> (ø)
python 68.35% <ø> (-0.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/amici/__init__.py 90.69% <ø> (ø)
python/amici/gradient_check.py 85.86% <0.00%> (-11.96%) ⬇️
src/spline.cpp 65.59% <0.00%> (-6.46%) ⬇️
include/amici/sundials_matrix_wrapper.h 89.23% <0.00%> (-3.08%) ⬇️
src/sundials_matrix_wrapper.cpp 80.65% <0.00%> (-0.41%) ⬇️

@dweindl dweindl requested a review from FFroehlich July 14, 2022 08:26
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@FFroehlich FFroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dweindl dweindl merged commit ac15f39 into develop Jul 15, 2022
@dweindl dweindl deleted the fix_1829 branch July 15, 2022 15:15
@dweindl dweindl linked an issue Jul 18, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python package installation fails with setuptools-63.2.0
2 participants