move sim_steps increment #1806

plakrisenko · 2022-06-10T16:47:00Z

moved sim_steps increment to the beginning of the while loop, as otherwise if the simulation is successful on the first step resulting sim_steps = 0.

moved also the max steps check and the large time point check, as otherwise one step is made even if maxSteps is set to zero

codecov · 2022-06-10T17:00:08Z

Codecov Report

Merging #1806 (9810581) into develop (477fd1b) will increase coverage by 0.06%.
The diff coverage is 71.42%.

@@             Coverage Diff             @@
##           develop    #1806      +/-   ##
===========================================
+ Coverage    76.37%   76.43%   +0.06%     
===========================================
  Files           74       74              
  Lines        12667    12667              
===========================================
+ Hits          9674     9682       +8     
+ Misses        2993     2985       -8

Flag	Coverage Δ
cpp	`72.71% <71.42%> (-0.03%)`	⬇️
petab	`60.59% <ø> (ø)`
python	`68.19% <ø> (+0.23%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/steadystateproblem.cpp	`85.02% <71.42%> (ø)`
src/sundials_matrix_wrapper.cpp	`80.24% <0.00%> (-0.41%)`	⬇️
python/amici/conserved_quantities_demartino.py	`65.55% <0.00%> (+1.95%)`	⬆️