Fix recent cmake-based build issues due to changed sundials library directory #1756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some package changed on GitHub Actions, not sure which exactly. But now sundials libraries are in expected in a different directory than before. Let CMake figure it out. Fixes errors of type ``` make[5]: *** No rule to make target '/home/runner/work/AMICI/AMICI/ThirdParty/sundials/build/lib/x86_64-linux-gnu/libsundials_nvecserial.a', needed by 'swig/__model_neuron.so'. ```
Codecov Report
@@ Coverage Diff @@
## develop #1756 +/- ##
============================================
+ Coverage 65.14% 77.84% +12.69%
============================================
Files 30 74 +44
Lines 4241 12018 +7777
============================================
+ Hits 2763 9355 +6592
- Misses 1478 2663 +1185
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This reverts commit 287c0ad.
dweindl
changed the title
FFroehlich
approved these changes
Apr 4, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some package changed on GitHub Actions, not sure which exactly. But now sundials libraries are expected in a different directory than before. Let CMake figure it out.
Fixes errors of type
Previous setup still worked here, but failed here.
The problem is, that on certain OSs,
CMAKE_INSTALL_LIBDIRtakes a different value, depending onCMAKE_INSTALL_PREFIX, andCMAKE_INSTALL_LIBDIRfrom AMICI does not necessarily match the one from sundials.