Fix undefined reference to dladdr #1738

kristianmeyerr · 2022-03-23T12:49:32Z

The explicit linking to libdl can avoid undefined reference to dladdr on some ubuntu systems.

codecov · 2022-03-23T13:06:51Z

Codecov Report

Merging #1738 (f231d95) into develop (f5e5258) will increase coverage by 0.36%.
The diff coverage is n/a.

❗ Current head f231d95 differs from pull request most recent head c820758. Consider uploading reports for the commit c820758 to get more accurate results

@@             Coverage Diff             @@
##           develop    #1738      +/-   ##
===========================================
+ Coverage    77.82%   78.18%   +0.36%     
===========================================
  Files           73       73              
  Lines        11364    11471     +107     
===========================================
+ Hits          8844     8969     +125     
+ Misses        2520     2502      -18

Flag	Coverage Δ
cpp	`75.29% <ø> (+0.61%)`	⬆️
petab	`62.51% <ø> (ø)`
python	`68.20% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/spline.cpp	`65.26% <0.00%> (-6.32%)`	⬇️
src/hdf5.cpp	`89.66% <0.00%> (-0.86%)`	⬇️
src/rdata.cpp	`93.12% <0.00%> (-0.64%)`	⬇️
src/steadystateproblem.cpp	`82.68% <0.00%> (-0.61%)`	⬇️
src/model.cpp	`85.42% <0.00%> (-0.60%)`	⬇️
src/exception.cpp	`74.19% <0.00%> (ø)`
include/amici/rdata.h	`94.44% <0.00%> (ø)`
python/amici/numpy.py	`82.60% <0.00%> (ø)`
include/amici/solver.h	`100.00% <0.00%> (ø)`
include/amici/newton_solver.h	`100.00% <0.00%> (ø)`
... and 10 more

dweindl · 2022-03-23T13:22:46Z

Thanks @kristianmeyerr

For future reference: This is required if AMICI is to be used without HDF5. When using HDF5, libdl comes in as transitive dependency so that this issue never surfaced here.