Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sundials' KLU_INDEXTYPE match actual klu index type #1733

Merged
merged 7 commits into from
Mar 18, 2022

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Mar 17, 2022

This is currently not the case on Windows and OSX, where long is only 32bit.

This is currently not the case on Windows
@codecov
Copy link

codecov bot commented Mar 17, 2022

Codecov Report

Merging #1733 (da7c8cd) into develop (1995d7b) will increase coverage by 10.24%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #1733       +/-   ##
============================================
+ Coverage    68.58%   78.83%   +10.24%     
============================================
  Files           29       73       +44     
  Lines         4132    11373     +7241     
============================================
+ Hits          2834     8966     +6132     
- Misses        1298     2407     +1109     
Flag Coverage Δ
cpp 74.53% <ø> (?)
petab 62.51% <ø> (ø)
python 71.32% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/vector.cpp 89.02% <0.00%> (ø)
include/amici/backwardproblem.h 100.00% <0.00%> (ø)
src/solver_idas.cpp 36.87% <0.00%> (ø)
src/rdata.cpp 93.12% <0.00%> (ø)
include/amici/misc.h 80.00% <0.00%> (ø)
include/amici/forwardproblem.h 100.00% <0.00%> (ø)
include/amici/sundials_matrix_wrapper.h 88.52% <0.00%> (ø)
src/solver.cpp 76.33% <0.00%> (ø)
src/sundials_matrix_wrapper.cpp 79.58% <0.00%> (ø)
include/amici/vector.h 77.27% <0.00%> (ø)
... and 49 more

@dweindl dweindl requested a review from FFroehlich March 17, 2022 10:40
@dweindl dweindl requested a review from FFroehlich March 17, 2022 16:45
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@FFroehlich FFroehlich merged commit b5927c2 into develop Mar 18, 2022
@FFroehlich FFroehlich deleted the fix_klu_index branch March 18, 2022 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants