Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check condition number when computing sensitivities via newton #1730

Merged
merged 20 commits into from
Mar 18, 2022
Merged

Check condition number when computing sensitivities via newton #1730

merged 20 commits into from
Mar 18, 2022

Conversation

FFroehlich
Copy link
Member

needs #1729, fixes #672

@FFroehlich FFroehlich requested a review from dweindl March 16, 2022 20:05
dweindl
dweindl approved these changes Mar 16, 2022
View reviewed changes
Copy link
Member

@dweindl dweindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

src/newton_solver.cpp Outdated Show resolved Hide resolved
src/newton_solver.cpp Outdated Show resolved Hide resolved
src/newton_solver.cpp Outdated Show resolved Hide resolved
src/newton_solver.cpp Outdated Show resolved Hide resolved
src/newton_solver.cpp Outdated Show resolved Hide resolved
src/newton_solver.cpp Outdated Show resolved Hide resolved
src/newton_solver.cpp Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 16, 2022 •
edited
Loading

Codecov Report

Merging #1730 (5aa11e6) into develop (dd5271e) will increase coverage by 0.08%.
The diff coverage is 70.37%.

❗ Current head 5aa11e6 differs from pull request most recent head 6db05ce. Consider uploading reports for the commit 6db05ce to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1730      +/-   ##
===========================================
+ Coverage    77.69%   77.77%   +0.08%     
===========================================
  Files           73       73              
  Lines        11373    11392      +19     
===========================================
+ Hits          8836     8860      +24     
+ Misses        2537     2532       -5
Flag Coverage Δ
cpp 74.61% <70.37%> (-0.01%) ⬇️
petab 62.51% <ø> (ø)
python 68.20% <ø> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
include/amici/newton_solver.h 33.33% <ø> (ø)
src/newton_solver.cpp 70.96% <70.37%> (-1.42%) ⬇️
src/sundials_matrix_wrapper.cpp 80.04% <0.00%> (+0.45%) ⬆️
python/amici/conserved_moieties.py 65.75% <0.00%> (+1.95%) ⬆️

@FFroehlich FFroehlich merged commit af0cf5f into develop Mar 18, 2022
@FFroehlich FFroehlich deleted the fix_672 branch March 18, 2022 15:21
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@dweindl dweindl linked an issue Mar 25, 2022 that may be closed by this pull request
Check condition number in NewtonSolver::getSens #672
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dweindl dweindl dweindl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check condition number in NewtonSolver::getSens
2 participants
@FFroehlich @dweindl