Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Use Ubuntu 22.04 #1708

Merged
merged 2 commits into from
May 21, 2022
Merged

CI: Use Ubuntu 22.04 #1708

merged 2 commits into from
May 21, 2022

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Mar 11, 2022

Run all tests on Ubuntu 22.04, except for Matlab tests, as Matlab actions don't support 22.04 yet.

@dweindl dweindl self-assigned this Mar 11, 2022
@dweindl dweindl force-pushed the ubuntu_22.04 branch 2 times, most recently from 9378920 to b6de835 Compare March 14, 2022 09:41
@dweindl
Copy link
Member Author

dweindl commented May 6, 2022

New Ubuntu images are meanwhile available (public beta).

Matlab action is not support there yet:

Dependencies are not available for MATLAB 'r2022a' on 'Ubuntu:jammy'. Use 'R2020a' or a later release on a supported Ubuntu distribution.

@codecov
Copy link

codecov bot commented May 6, 2022

Codecov Report

Merging #1708 (8eca67d) into develop (335615c) will decrease coverage by 0.77%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1708      +/-   ##
===========================================
- Coverage    77.56%   76.78%   -0.78%     
===========================================
  Files           74       74              
  Lines        12349    12610     +261     
===========================================
+ Hits          9578     9683     +105     
- Misses        2771     2927     +156     
Flag Coverage Δ
cpp 73.06% <ø> (-1.21%) ⬇️
petab 60.75% <ø> (ø)
python 68.45% <ø> (+0.25%) ⬆️
sbmlsuite 88.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/model_ode.cpp 66.80% <0.00%> (-4.20%) ⬇️
src/vector.cpp 87.09% <0.00%> (-1.80%) ⬇️
src/model.cpp 78.94% <0.00%> (-1.77%) ⬇️
src/edata.cpp 86.79% <0.00%> (-1.55%) ⬇️
src/hdf5.cpp 89.15% <0.00%> (-1.54%) ⬇️
src/steadystateproblem.cpp 85.02% <0.00%> (-1.39%) ⬇️
src/solver.cpp 76.26% <0.00%> (-1.37%) ⬇️
src/abstract_model.cpp 3.82% <0.00%> (-0.94%) ⬇️
src/amici.cpp 72.53% <0.00%> (-0.80%) ⬇️
src/sundials_matrix_wrapper.cpp 80.65% <0.00%> (-0.77%) ⬇️
... and 16 more

@dweindl dweindl marked this pull request as ready for review May 20, 2022 17:24
@dweindl dweindl requested a review from FFroehlich May 20, 2022 17:24
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dweindl dweindl merged commit 5f5e260 into develop May 21, 2022
@dweindl dweindl deleted the ubuntu_22.04 branch May 21, 2022 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants