Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SBML import: Raise in case of nested observables #1690

Merged
merged 1 commit into from
Mar 1, 2022
Merged

SBML import: Raise in case of nested observables #1690

merged 1 commit into from
Mar 1, 2022

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Feb 28, 2022

Closes #1689

@codecov
Copy link

codecov bot commented Feb 28, 2022 •
edited
Loading

Codecov Report

Merging #1690 (6b5a709) into develop (e8e46ac) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1690      +/-   ##
===========================================
+ Coverage    78.37%   78.40%   +0.03%     
===========================================
  Files           70       70              
  Lines        11368    11371       +3     
===========================================
+ Hits          8910     8916       +6     
+ Misses        2458     2455       -3
Flag Coverage Δ
cpp 75.43% <ø> (+0.04%) ⬆️
petab 62.88% <100.00%> (+0.02%) ⬆️
python 68.47% <100.00%> (+0.02%) ⬆️
sbmlsuite 89.08% <0.00%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/amici/sbml_import.py 95.96% <100.00%> (+0.01%) ⬆️
src/solver_cvodes.cpp 71.29% <0.00%> (+0.18%) ⬆️
src/exception.cpp 80.64% <0.00%> (+6.45%) ⬆️

@dweindl dweindl requested a review from FFroehlich February 28, 2022 23:22
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

42.9% 42.9% Coverage
0.0% 0.0% Duplication

FFroehlich
FFroehlich approved these changes Feb 28, 2022
View reviewed changes
Copy link
Member

@FFroehlich FFroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dweindl dweindl merged commit 3c6bd41 into develop Mar 1, 2022
@dweindl dweindl deleted the fix_1689_obsobs branch March 1, 2022 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FFroehlich FFroehlich FFroehlich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dweindl @FFroehlich