Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: Add AMICI_CXX_OPTIONS #1664

Merged
merged 5 commits into from
Feb 8, 2022
Merged

cmake: Add AMICI_CXX_OPTIONS #1664

merged 5 commits into from
Feb 8, 2022

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Feb 7, 2022

to set libamici-specific compiler options.

@codecov
Copy link

codecov bot commented Feb 7, 2022

Codecov Report

Merging #1664 (0c79e56) into develop (e6ab2bc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1664   +/-   ##
========================================
  Coverage    78.75%   78.75%           
========================================
  Files           69       69           
  Lines        10732    10732           
========================================
  Hits          8452     8452           
  Misses        2280     2280           
Flag Coverage Δ
cpp 75.24% <ø> (ø)
petab 66.70% <ø> (ø)
python 68.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dweindl dweindl requested a review from FFroehlich February 7, 2022 21:23
Copy link
Member

@FFroehlich FFroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what happened to set(ENABLE_SWIG ON)?

@dweindl
Copy link
Member Author

dweindl commented Feb 8, 2022

what happened to set(ENABLE_SWIG ON)?

Got removed. I don't know what it was supposed to do. It's enabled by default further down in option(ENABLE_SWIG "Build AMICI swig library?" ON)

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dweindl dweindl merged commit ee1f445 into develop Feb 8, 2022
@dweindl dweindl deleted the fix_cxxflags branch February 8, 2022 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build scripts: use -Werror only for AMICI sources, not for third-party code
2 participants