Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix using x_pos in all model functions #1650

Merged
merged 6 commits into from
Feb 2, 2022
Merged

Conversation

FFroehlich
Copy link
Member

No description provided.

@FFroehlich FFroehlich requested a review from dweindl February 2, 2022 04:21
@codecov
Copy link

codecov bot commented Feb 2, 2022

Codecov Report

Merging #1650 (c94ec9c) into develop (4d65631) will decrease coverage by 0.00%.
The diff coverage is 89.65%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1650      +/-   ##
===========================================
- Coverage    78.87%   78.87%   -0.01%     
===========================================
  Files           69       69              
  Lines        10717    10735      +18     
===========================================
+ Hits          8453     8467      +14     
- Misses        2264     2268       +4     
Flag Coverage Δ
cpp 75.43% <89.65%> (+<0.01%) ⬆️
petab 66.68% <ø> (ø)
python 68.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
include/amici/model.h 60.86% <ø> (ø)
src/model.cpp 84.42% <89.65%> (-0.02%) ⬇️
src/spline.cpp 65.26% <0.00%> (-6.32%) ⬇️
src/solver_cvodes.cpp 71.29% <0.00%> (+0.18%) ⬆️
src/sundials_matrix_wrapper.cpp 82.33% <0.00%> (+0.45%) ⬆️
src/exception.cpp 80.64% <0.00%> (+6.45%) ⬆️

Copy link
Member

@dweindl dweindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks.

src/model.cpp Show resolved Hide resolved
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 2, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@FFroehlich FFroehlich merged commit 72abd12 into develop Feb 2, 2022
@FFroehlich FFroehlich deleted the fix_rdata_outputs branch February 2, 2022 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants